Warning about push constants

shader-slang · Feb 4, 2025 · 160f81a · 160f81a
1 parent 0a68285
commit 160f81a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/source/slang/slang-parameter-binding.cpp b/source/slang/slang-parameter-binding.cpp
@@ -1073,6 +1073,12 @@ static void _maybeDiagnoseMissingVulkanLayoutModifier(
     ParameterBindingContext* context,
     DeclRef<VarDeclBase> const& varDecl)
 {
+    // Don't warn if the declaration is a vk::push_constant
+    if (varDecl.getDecl()->hasModifier<PushConstantAttribute>())
+    {
+        return;
+    }
+
     // If the user didn't specify a `binding` (and optional `set`) for Vulkan,
     // but they *did* specify a `register` for D3D, then that is probably an
     // oversight on their part.

diff --git a/tests/diagnostics/vk-bindings.slang b/tests/diagnostics/vk-bindings.slang
@@ -14,6 +14,9 @@ struct S { float4 a; };
 [[vk::binding(2,1)]]
 ParameterBlock<S> b;
 
+[[vk::push_constant]] \
+ConstantBuffer<int> gint : register(b0, space0);
+
 [shader("compute")]
 void main()
-{}
+{}