Add qslim decimation feature #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I don't know that it is worth changing the default (and therefore turning this into a breaking change). If anything, I say we merge it as it is, and consider changing the default behaviour in the next major release (we can even make the PR after this is merged and label it as a breaking change ready to merge). Re. bumping libigl: I agree we should do it, but let's do it in a different PR. Otherwise we can fall into the "one PR does many things" trap. |
sgsellan
added
the
ready to merge
sgsellan
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default libigl behavior for decimate is shortest edge decimation. With this PR, people can use our decimate function to choose between libigl's shortest edge and qslim implementations.
Default behavior as of this PR is shortest edge. Do we want to keep it that way?
Also, we should consider bumping the libigl version - newer libigl versions can prevent self-intersections in decimation.