Fix issue with output_limit affecting analysis instead of just output. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgb-io
reviewed
Oct 20, 2023
| let expected_output = "No output format specified."; | ||
| assert_eq!(output_str, expected_output); | ||
| } | ||
|
|
||
| #[test] | ||
| fn test_output_json_format() { | ||
| let file_data_list = get_test_data(); | ||
| let output_str = generate_output(&file_data_list, "json".to_string(), &0.1_f64); | ||
| let output_str = generate_output(&file_data_list, "json".to_string(), &0.1_f64, 100); | ||
|
|
||
| let expected_output = r##"[ | ||
| { |
There was a problem hiding this comment.
Is there actually a test for this behaviour being correct?
It seems to me that the existing tests were not catching this problem so probably a new test is needed
There was a problem hiding this comment.
As discussed offline, covering this bug is challenging at the moment because it occurs in the top-level analyze fn. Covering this fn will require some fairly heavy refactoring so that we can mock the relevant things such as walking the filesystem to read source code (and later doing the analysis). TBC if we will carry on as-is or add tests
…t-complex-files-and-skips-checking-the-score-entirely
Closed
sgb-io
reviewed
Oct 20, 2023
sgb-io
deleted the
46-fta-cli-limiting-output-does-not-show-most-complex-files-and-skips-checking-the-score-entirely
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with output_limit affecting analysis instead of just output.