fix UI crasher caused by negative (unexpected) colorspace vrgb components. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents.
The following code somehow results in negative r value component:
```C++
ColorSpaces::vec3 vrgb = ColorSpaces::hcy_to_rgb(vhcy);
```
... while hcy_to_rgb() itself calculates `vec3` (`std::array<float,3>`) as
expected. Negative components then leads to runtime crash.
Considering that the function might return negative values anyway, filter
out those negative values here at SColorRGB constructor to sanitize inputs.
|
Some contexts: attaching how the relevant code looks on CLion debugger (lldb). At 
At 
|
|
Since nobody had complained about this, it is likely specific to macOS arm64 environment (the build has been broken for a while, which likely means no one tried to build it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code somehow results in negative r value component:
... while hcy_to_rgb() itself calculates
vec3(std::array<float,3>) as expected. Negative components then leads to runtime crash.Considering that the function might return negative values anyway, filter out those negative values here at SColorRGB constructor to sanitize inputs.