Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to DataFusion 28 and Arrow 43 #518

Closed
wants to merge 10 commits into from

Conversation

gruuya
Copy link
Contributor

@gruuya gruuya commented Jul 20, 2023

Also upgrade and align with sqlparser 0.35.

Closes #493.

@gruuya
Copy link
Contributor Author

gruuya commented Jul 21, 2023

@wangxiaoying I have noticed that builds are failing due to hard-coded toolchain versions, which become obsolete after running cargo update. First it was:

package `constant_time_eq v0.3.0` cannot be built because it requires rustc 1.66.0 or newer, while the currently active rustc version is 1.65.0

and when I bumped the version to 1.66.0 it is

package `half v2.3.1` cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.66.0

Any reason not to set this to stable (or nightly for that matter)?

@gruuya gruuya changed the title Upgrade to DataFusion 27 and Arrow 42 Upgrade to DataFusion 28 RC and Arrow 43 Jul 24, 2023
@gruuya gruuya changed the title Upgrade to DataFusion 28 RC and Arrow 43 Upgrade to DataFusion 28 and Arrow 43 Jul 27, 2023
@wangxiaoying
Copy link
Contributor

Hi @gruuya, thanks for the PR, and sorry for the late reply!

Any reason not to set this to stable (or nightly for that matter)?

Previously we need to use a specific version, but now I think we can change it to stable.

I have a branch arrow-stream that is waiting to merge (pr #536) after sorting out the Conda release. It adds arrow stream as a new destination with different implementation logic and has bumped arrow and datafusion version to 40 and 26. Is it possible if you can apply your modifications to that?

@gruuya
Copy link
Contributor Author

gruuya commented Sep 11, 2023

I have a branch arrow-stream that is waiting to merge (pr #536) after sorting out the Conda release. It adds arrow stream as a new destination with different implementation logic and has bumped arrow and datafusion version to 40 and 26. Is it possible if you can apply your modifications to that?

Oh certainly, I can re-base/open a new PR once that is merged. Or did you have something else in mind?

@wangxiaoying
Copy link
Contributor

Oh certainly, I can re-base/open a new PR once that is merged. Or did you have something else in mind?

I just merged arrow-stream branch to main. Can you rebase this one (or reopen a new one if you like) on the current main branch? Thank you!

@gruuya
Copy link
Contributor Author

gruuya commented Sep 13, 2023

Closing in favor of #540.

@gruuya gruuya closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies to latest versions
2 participants