add set_labels to clean_names()

[jospueyo]

Implements #563.

I added the set_labels argument ensuring backward compatibility for default (not for dimnames) and sf methods. I'm not confident enough with tidygraph to implement the method for that.

I did not create labels when dimnames is used because I thought when dimnames is used, dat is probably a matrix, which doesn't accept column labels, am I right?

I tested for both methods.

I added the new feature in NEWS and myself as a contributor in the DESCRIPTION (thanks for this).

Also, I fixed a note regarding a bad header in NEWS (line 27).

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (709b2ab) to head (4d135fd).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #564   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         1401      1408    +7     
=========================================
+ Hits          1401      1408    +7     

Files with missing lines	Coverage Δ
R/clean_names.R	100.00% <100.00%> (ø)

[billdenney]

This looks good to me, overall. I have a few minor comments and one note for @sfirke where I don't know as much about the sf package.

[billdenney]

I have two last requests:

• Please add text like "To convert the labels back to column names, see the sjlabelled::label_to_colnames() function." in the details section of the docs. (See the issues discussion for the rationale.)
• Please separate the sf package tests into a separate test_that() block with skip_if_not_installed("sf") so that the tests will work even if sf is not installed.

[jospueyo]

I have two last requests:

* Please add text like "To convert the labels back to column names, see the `sjlabelled::label_to_colnames()` function." in the details section of the docs.  (See the issues discussion for the rationale.)

* Please separate the `sf` package tests into a separate `test_that()` block with `skip_if_not_installed("sf")` so that the tests will work even if `sf` is not installed.

Added.

[billdenney]

Thanks! @sfirke , I think that this is ready to merge (if all the tests that are now running succeed).

[olivroy]

I think this feature would be great! @sfirke, when you have the chance, could you take a look.

@jospueyo there are some merge conflicts right now. Would help to resolve them to help get the PR merged :)

[jospueyo]

I think this feature would be great! @sfirke, when you have the chance, could you take a look.

@jospueyo there are some merge conflicts right now. Would help to resolve them to help get the PR merged :)

I updated the PR, there aren't any conflicts now.