-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add set_labels to clean_names() #564
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1401 1408 +7
=========================================
+ Hits 1401 1408 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, overall. I have a few minor comments and one note for @sfirke where I don't know as much about the sf
package.
I have two last requests:
|
Added. |
Thanks! @sfirke , I think that this is ready to merge (if all the tests that are now running succeed). |
Implements #563.
I added the
set_labels
argument ensuring backward compatibility for default (not for dimnames) and sf methods. I'm not confident enough with tidygraph to implement the method for that.I did not create labels when dimnames is used because I thought when dimnames is used,
dat
is probably a matrix, which doesn't accept column labels, am I right?I tested for both methods.
I added the new feature in NEWS and myself as a contributor in the DESCRIPTION (thanks for this).
Also, I fixed a note regarding a bad header in NEWS (line 27).