Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added secrets management, a CI pipeline, and formatters #84

Open
wants to merge 78 commits into
base: master
Choose a base branch
from
Open

Added secrets management, a CI pipeline, and formatters #84

wants to merge 78 commits into from

Conversation

agennadi
Copy link
Collaborator

@agennadi agennadi commented Nov 15, 2024 •
edited
Loading

Description

  1. Introduced a pre-commit-hook for Black, ESLint, MyPy.
  2. Ran Black, ESLint, MyPy locally and refactored the code.
  3. Added required environment variables to GitHub secrets.
  4. Created a GitHub workflow Generate .env file that can be manually triggered by contributors with write access. Rationale: we don't want to commit our .env file to the repo for security reasons. However, developers need access to these variables to run the project locally. As a temporary solution, contributors can:
  • Get write access.
  • Trigger the Generate .env File workflow.
  • Download the generated .env file artifact.
  • Place the downloaded .env file in the root folder of the project.
    A sanity check on this workflow is appreciated!
  1. Created a CI pipeline that runs on PRs: checks code formatting, builds docker containers, and runs tests inside them.
  2. Updated README.

#43 #64

Type of changes

  • Bugfix
  • Chore
  • New Feature

Testing

  • I added automated tests
  • I think tests are unnecessary

How to test

We finally have a CI pipeline that runs tests in docker for us (yay!)

oscarsyu and others added 30 commits August 23, 2024 19:12
@oscarsyu
reorg files
22da22d
@oscarsyu
reorg files
6d7ebcd
@mackcooper1408
Update issue templates
5cad70a
@mackcooper1408
Update issue templates
7071f2a
@mackcooper1408 @AdamFinkle
Create PR template
3ba94ec
@mackcooper1408 @AdamFinkle
fix checkboxes
fdc7434
@AdamFinkle @mackcooper1408
Set up Next and FastAPI (#6)
b8de551 
* Set up Next and FastAPI

* Removed .next cache and pycache.

* update gitignore

* clear cache

* update gitignore pt 2

---------

Co-authored-by: Mack Cooper <[email protected]>
@katiefg
added my changes to existing master, requirements.txt in streamlit_ap…
074864d 
…p dir is associated with requirements for streamlit app specifically
@katiefg
additional data and requirements files
fffe903
@mantuok
chakra installed and apllied, custom theme defined
ac307c5
@mantuok
changed background color to test custom theme
d1084f4
@mantuok
Merge pull request #40 from sfbrigade/integrate_chakraui
3ea3220 
Integrate chakraUI
@oscarsyu
Create data-science-template.md
3058f1e
@oscarsyu
Merge pull request #8 from sfbrigade/KG/dataexplore
bdf7506 
Integrating streamlit app updates
@mantuok
Clean up and configure web app (#47)
7a1a537 
* cleared page.tsx, added blank lines

* cleared layout.tsx

* cleared global.css

* installed Prettier, configured Prettier and ESLint

* Updated prettierignore list
@mantuok
Set up routing (#48)
a77deb6 
* cleared page.tsx, added blank lines

* created folders and files

* added content to the pages and configured routing

* corrected formatting

* added map view

* added page-not-found

* updated page not found

* updated according to comments
@mantuok
Component test page (#51)
c919795 
* created components test page

* created a mock button component

* Mock button updated and added to test lib

* components lib added and mock button updated

* updated according to comments
@AdamFinkle
Backend (#55)
48ab4ac 
* Copied combined changes.

* Added pytest.

* Split models by concern.

* Moved each model into own python file.

* Deleted test_index.py

* Pruned TODO
@mantuok
jest installed, configured, mock test created and passed (#58)
e8ac7d3
@mantuok
Base application layout (#59)
48b435f 
* basic layout for home page

* added sizes and paddings

* refactoring

* refactoring
@agennadi
Fix api tests (#57)
0eb73c9 
* Copied combined changes.

* Split models by concern.

* deleted test_index, added test_polygons

* deleted trailing space in .prettierrc
---------
Co-authored-by: AdamFinkle <[email protected]>
Co-authored-by: Anna Gennadinik <[email protected]>
@agennadi @AdamFinkle @katiefg
Dockerized the application (#61)
25be1e0 
* Copied combined changes.

* Added pytest.

* Split models by concern.

* Moved each model into own python file.

* Deleted test_index.py

* Pruned TODO

* Created mock database and tests.

* dockerized backend, frontend, db; added mock data; wrote db tests

* cleaned up code

* Added script for soft stories.
>
>
Co-authored-by: katiefg <[email protected]>
Co-authored-by: AdamFinkle <[email protected]>

* added script for soft stories

* Created script for soft stories.

Co-authored-by: katiefg <[email protected]>
Co-authored-by: AdamFinkle <[email protected]>

* minor refactoring

* modified package.json

* modified compose.yaml

* modified compose.yaml

* Added geopandas

Co-authored-by: katiefg <[email protected]>

* Co-authored-by: @katiefg

* Added comment about insecure request

* updated README

* resolved merge conflicts

* refactored tests

---------

Co-authored-by: AdamFinkle <[email protected]>
Co-authored-by: Anna Gennadinik <[email protected]>
Co-authored-by: katiefg <[email protected]>
Co-authored-by: AdamFinkle <[email protected]>
@agennadi
set variables in .env file and added config.py for fastAPI
1040642
@agennadi
updated the env file compose-docker
e96b281
@agennadi
added next.js env variable; updated dockerfile
ebb0d66
@agennadi
updated README
63d807a
@agennadi
modified README
da55682
@agennadi
made .env temporary available
cfab8e1
@mantuok
Add design tokens (#62)
6b42bce 
* added and applied colors

* font added

* text styles added

* text styles added

* sizes and paddings updated

* font colors added to textStyles

* updated logo font weight
@agennadi
Merge remote-tracking branch 'origin/master' into configure_app_envs
28a9d30
@agennadi
temporarily removed db step
ef1ffa4
@agennadi
added workflow for env file
81331f9
@agennadi
added trigger on push
b3f4d5e
@agennadi
created empty env file
052af8f
@agennadi
edited the apth
fc902cb
@agennadi
use external action to crreate envfile
051d384
@agennadi
added steps to verify and upload envfile
cf911dd
@agennadi
updated the path
8186e45
@agennadi
debugging the artifact
5dcb0f6
@agennadi
updated github workflows and env config
c60a40e
@agennadi
updated gitignore
f6b0b1b
@agennadi
env file retrieved in ci pipeline
d75bcf6
@agennadi
download env artifact from another workflow
c663a1f
@agennadi
edited test command
73ca79f
@agennadi
changed test folder
0f245d1
@agennadi
changed test path
e9cbf28
@agennadi
changed command for running tests
c7f2995
@agennadi
added most recent run as a variable
724247a
@agennadi
updated readme
dff6e86
@agennadi
Merge branch 'master' into add_ci_and_linting
01a1551
@agennadi
deleted unused reqs
770396b
@agennadi
minor refactoring
24b228d
@agennadi
ran formatters
c48b781
@agennadi
updated types of actions to trigger pipeline
067c412
@agennadi agennadi marked this pull request as draft November 15, 2024 00:48
@agennadi agennadi marked this pull request as ready for review November 15, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agennadi @oscarsyu @mackcooper1408 @AdamFinkle @katiefg @mantuok