Deploy to Google Cloud #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codetheweb
commented
Jul 25, 2023
| * This script injects Google Cloud metadata (when available) into the environment. | ||
| * Specifically, it injects the NEXTAUTH_URL and BASE_HTTP_ENDPOINT environment variables. | ||
| * Run with `npm run with-gcp-metadata <command> <args>`. | ||
| */ |
There was a problem hiding this comment.
very frustrating: the generated cloud run URL isn't known until after the deploy, and terraform blocks can't reference themselves
I think this is the cleanest solution, didn't see anything simpler online
There was a problem hiding this comment.
NEXAUTH_URL will be our domain, e.g. [staging.]compassiep.com
There was a problem hiding this comment.
yes, however ideally we can deploy without a domain/with the generated one with necessary
it'd be nice to be able to deploy to a new project or a personal account for testing
amantri
approved these changes
Jul 25, 2023
| * This script injects Google Cloud metadata (when available) into the environment. | ||
| * Specifically, it injects the NEXTAUTH_URL and BASE_HTTP_ENDPOINT environment variables. | ||
| * Run with `npm run with-gcp-metadata <command> <args>`. | ||
| */ |
There was a problem hiding this comment.
NEXAUTH_URL will be our domain, e.g. [staging.]compassiep.com
| name = "DATABASE_URL" | ||
| value_source { | ||
| secret_key_ref { | ||
| secret = google_secret_manager_secret.database_url.secret_id |
Co-authored-by: Anup Mantri <[email protected]>
jonahchoi
pushed a commit
that referenced
this pull request
Jul 28, 2023
Co-authored-by: Anup Mantri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's missing: