MVP data models for goals, subgoals(benchmarks), tasks. #157

jonahchoi · 2023-07-22T00:54:51Z

#90 :

Added tables for goals, subgoals, tasks, and collections
Added routes for IEP and para
Added some tests (not fully encompassing)
Modified frontend components to display new data

Worked with: @amantri @tessathornberry @hieungo89

…ct changes.

codetheweb

can't speak much to the data model but implementation is looking pretty good :)

codetheweb · 2023-07-23T23:23:04Z

src/backend/db/migrations/1_initial-migrations.sql

@@ -70,12 +71,44 @@ CREATE TABLE "goal" (
  goal_id UUID PRIMARY KEY DEFAULT uuid_generate_v4(), -- TODO: add index to allow reordering
  iep_id UUID REFERENCES "iep" (iep_id),
  description TEXT NOT NULL,
-  created_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
+  created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+  category TEXT NOT NULL CHECK (category IN ('writing', 'reading', 'math', 'other'))


🐧 convention has been to have "common" columns like created_at at the end of the table definition

codetheweb · 2023-07-23T23:27:28Z

src/backend/db/migrations/1_initial-migrations.sql

 );

 CREATE TABLE "subgoal" (
  subgoal_id UUID PRIMARY KEY DEFAULT uuid_generate_v4(), -- TODO: add index to allow reordering
  goal_id UUID REFERENCES "goal" (goal_id),
  description TEXT NOT NULL,
-  created_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
+  created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+  instructions TEXT,


🐧 I'd probably make this not null and default to ""

src/backend/db/migrations/1_initial-migrations.sql

codetheweb · 2023-07-23T23:31:01Z

src/backend/db/migrations/1_initial-migrations.sql

+
+  -- Optional depending on type of task
+  notes TEXT,
+  image_list TEXT[]


it doesn't look like this is being used yet so I might remove it
this should point to file_ids, it's usually a bit of an antipattern to store arrays in sql

I agree. I was thinking of having files reference trials, but kind of left it here as a placeholder since it wasn't essential yet. I'll remove it for now.

codetheweb · 2023-07-23T23:33:27Z

src/components/case_manager/PersonTable.tsx

-      <form onSubmit={onSubmit} id="table_input_form"></form>
+      <form
+        onSubmit={(event: React.FormEvent<HTMLFormElement>) => {
+          onSubmit(event);


type for onSubmit should be updated above to return Promise<void> | void and then we can await it here to prevent resetting the form if onSubmit is async and throws

codetheweb · 2023-07-23T23:33:40Z

src/components/case_manager/PersonTable.tsx

+          const form = document.getElementById("table_input_form");
+          (form as HTMLFormElement).reset();


Suggested change

const form = document.getElementById("table_input_form");

(form as HTMLFormElement).reset();

event.target.reset()

Oops, I was playing around with this for Tessa's issue and forgot to remove it. But thank you for this optimization! I'll let Tessa know about it.

amantri · 2023-07-25T01:11:47Z

src/backend/db/migrations/1_initial-migrations.sql

@@ -45,7 +45,8 @@ CREATE TABLE "student" (
  first_name TEXT NOT NULL,
  last_name TEXT NOT NULL,
  email TEXT NOT NULL UNIQUE,
-  assigned_case_manager_id UUID REFERENCES "user" (user_id) ON DELETE SET NULL
+  assigned_case_manager_id UUID REFERENCES "user" (user_id) ON DELETE SET NULL,
+  grade SMALLINT


Where is this being used?

The newest mockups have grade on the student table and on students' pages. Although I forgot to implement it elsewhere. I can either a) remove it for now and let another issue handle it or b) write a todo comment.

In general, try to keep a PR self contained that is focused on a specific feature/bug. This field would ideally be in the PR that adds that to the frontend/backend, but since you have already added it here, I will leave it to your discretion if you want to leave it in or remove it :)

Got it. Sometimes I think of something and just toss it in, but I'll try to keep things more self contained from now on.

amantri · 2023-07-25T01:15:02Z

src/backend/db/migrations/1_initial-migrations.sql

  created_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
 );

 CREATE TABLE "subgoal" (
  subgoal_id UUID PRIMARY KEY DEFAULT uuid_generate_v4(), -- TODO: add index to allow reordering
  goal_id UUID REFERENCES "goal" (goal_id),
  description TEXT NOT NULL,
+  instructions TEXT NOT NULL DEFAULT '',


Suggested change

instructions TEXT NOT NULL DEFAULT '',

instructions TEXT NOT NULL DEFAULT "",

Consistent quotes

I tried this first, and found out that in SQL, single and double quotes actually have different meanings. Single quotes are for string literals, while double quotes are "delimited identifiers", meaning they reference tables or columns.

Ah - thanks for the info. TIL

amantri · 2023-07-25T01:17:18Z

src/backend/db/migrations/1_initial-migrations.sql

  created_at TIMESTAMPTZ NOT NULL DEFAULT NOW()
 );

 CREATE TABLE "subgoal" (
  subgoal_id UUID PRIMARY KEY DEFAULT uuid_generate_v4(), -- TODO: add index to allow reordering
  goal_id UUID REFERENCES "goal" (goal_id),
  description TEXT NOT NULL,
+  instructions TEXT NOT NULL DEFAULT '',
+  target_max_attempts INTEGER, --How many "questions" to administer in a single sitting


This depends on the type of subgoal this is - e.g. quantitative vs behavioral.

That's one reason I left it as an optional column. But I believe we discussed with Niko that our MVP would focus on one collection type, with plans to add more in the future. Maybe we can brainstorm better options for this?

SG. Let's get this PR merged in, and we can update it later.

amantri · 2023-07-27T21:37:55Z

src/backend/routers/iep.test.ts

@@ -32,4 +42,13 @@ test("basic flow - add/get goals and subgoals", async (t) => {
    goal_id: goal1!.goal_id,
  });
  t.is(gotSubgoals.length, 2);
+
+  t.truthy(


🐧 Ideally, we should be using our API methods instead of directly querying the db. We will likely need a getTasks method down the line when we want to do the Para schedule view. You can add a TODO for that now.

amantri

LGTM

* New task and data tables * Added task and data tables. Edited paraDash and taskCards to use db * Updated schemas * Updated all paratrial schemas. Updated routes and components to reflect changes. * Added new tests for para routes, adjusted test for iep route * Adjusted schemas, removed unrelated code. * Add todos in iep.test

jonahchoi added 5 commits July 15, 2023 14:05

New task and data tables

cd9bbed

Added task and data tables. Edited paraDash and taskCards to use db

6777833

Updated schemas

cef9730

Updated all paratrial schemas. Updated routes and components to refle…

9ca8dd8

…ct changes.

Added new tests for para routes, adjusted test for iep route

bcbdd56

codetheweb reviewed Jul 23, 2023

View reviewed changes

Adjusted schemas, removed unrelated code.

1880ee3

jonahchoi requested a review from codetheweb July 24, 2023 01:33

amantri approved these changes Jul 25, 2023

View reviewed changes

Merge branch 'main' into paraFlow

56f497f

amantri reviewed Jul 27, 2023

View reviewed changes

amantri approved these changes Jul 27, 2023

View reviewed changes

jonahchoi added 2 commits July 27, 2023 14:47

Merge branch 'main' into paraFlow

76e74eb

Add todos in iep.test

1bdc52e

jonahchoi merged commit 82c6534 into main Jul 27, 2023
3 checks passed

jonahchoi deleted the paraFlow branch August 7, 2023 23:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MVP data models for goals, subgoals(benchmarks), tasks. #157

MVP data models for goals, subgoals(benchmarks), tasks. #157

jonahchoi commented Jul 22, 2023 •

edited

Loading

codetheweb left a comment

codetheweb Jul 23, 2023

codetheweb Jul 23, 2023

codetheweb Jul 23, 2023

jonahchoi Jul 23, 2023

codetheweb Jul 23, 2023

codetheweb Jul 23, 2023

jonahchoi Jul 23, 2023

amantri Jul 25, 2023

jonahchoi Jul 26, 2023

amantri Jul 27, 2023

jonahchoi Jul 27, 2023

amantri Jul 25, 2023

jonahchoi Jul 26, 2023 •

edited

Loading

amantri Jul 27, 2023

amantri Jul 25, 2023

jonahchoi Jul 26, 2023

amantri Jul 27, 2023

amantri Jul 27, 2023

amantri left a comment

		const form = document.getElementById("table_input_form");
		(form as HTMLFormElement).reset();

	const form = document.getElementById("table_input_form");
	(form as HTMLFormElement).reset();
	event.target.reset()

	instructions TEXT NOT NULL DEFAULT '',
	instructions TEXT NOT NULL DEFAULT "",

MVP data models for goals, subgoals(benchmarks), tasks. #157

MVP data models for goals, subgoals(benchmarks), tasks. #157

Conversation

jonahchoi commented Jul 22, 2023 • edited Loading

codetheweb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonahchoi Jul 26, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amantri left a comment

Choose a reason for hiding this comment

jonahchoi commented Jul 22, 2023 •

edited

Loading

jonahchoi Jul 26, 2023 •

edited

Loading