Created sidebar, links hidden when user is signed out #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Co-authored by: Hannah McGowan <[email protected]
This was
linked to
issues
Jul 18, 2023
Closed
amantri
reviewed
Jul 18, 2023
jonahchoi
reviewed
Jul 18, 2023
| children: React.ReactNode; | ||
| } | ||
| const NavBar: React.FC<Props> = ({ children }) => { | ||
| const { data: me } = trpc.user.getMe.useQuery(); |
There was a problem hiding this comment.
While sitting on the sign in page, a 401: Unauthorized error toast pops up because its trying to use getMe without being logged in. Is there a way to prevent this? I think one possibility is to create a new backend procedure for this.
There was a problem hiding this comment.
Currently investigating our options
There was a problem hiding this comment.
We can create a separate issue for this, in the spirit of faster and smaller PRs.
jonahchoi
reviewed
Jul 27, 2023
src/pages/settings.tsx
Outdated
| @@ -0,0 +1,11 @@ | |||
| import React from "react"; | |||
|
|
|||
| const settings = () => { | |||
There was a problem hiding this comment.
We recently made the change to make sure all components are PascalCased, so please capitalize first letters.
jonahchoi
reviewed
Jul 27, 2023
src/pages/staff/index.tsx
Outdated
| import styles from "../../styles/Dashboard.module.css"; | ||
| import MyParas from "@/components/case_manager/MyParas"; | ||
|
|
||
| function staff() { |
jonahchoi
reviewed
Jul 27, 2023
src/pages/students/index.tsx
Outdated
|
|
||
| function cmDashboard() { | ||
| function students() { |
jonahchoi
approved these changes
Jul 27, 2023
jonahchoi
reviewed
Jul 27, 2023
| <Logout className={styles.icon} /> | ||
| <p | ||
| className={styles.linkTitle} | ||
| onClick={() => signOut({ callbackUrl: "/" })} |
There was a problem hiding this comment.
Why is this on a p tag inside a link? Can the Link just be a button instead?
jonahchoi
pushed a commit
that referenced
this pull request
Jul 28, 2023
* Created sidebar, links hidden when user is signed out > > Co-authored by: Hannah McGowan <[email protected] * added links to student and para tables, settings page under construction * redirect to students page upon login * updated table title * ran prettier on navbar styles * added type to Navbar props * resolved all issues except 401 error, fixed linting * removed React.FC, updated prop type * Pascal Casing * updated component exports * Fixed export casing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: Hannah McGowan [email protected]