Fix keychain prompt opening after idling #289
Conversation
After leaving the connection unused for 5 minutes (presumably that's the OS default for new keychains) the keychain locks and prompts the user to unlock, however there is a random password set and it can never be unlocked. To fix this we set the keychain to never lock.
| .password(&random_password()?) | ||
| .create(dir.path().join("identity.keychain"))?; | ||
|
|
||
| keychain.set_settings(&KeychainSettings::default())?; |
There was a problem hiding this comment.
Is the keychain not initialized with default settings?
There was a problem hiding this comment.
Apparently not, not on my macbook v. 14.3, but I also got reports from my users using all different kind of macOS versions
There was a problem hiding this comment.
Can you put together a test that shows the bad behavior? It's fine if it needs to sleep for 5 minutes or whatever - I just want to do some investigating.
There was a problem hiding this comment.
We have an internal test for this, give me a few days to put together a public one
|
Running into this as well. Is there any workaround? On MacOS my app will prompt for the "Identity keychain" after a while idling, and it's not even the user password. |
|
We temporarily fixed it by using our own fork and patching it ourselves. Sadly I don't have the time currently to dig further into the issue or add tests |
After leaving the connection unused for 5 minutes (presumably that's the OS default for new keychains) the keychain locks and prompts the user to unlock, however there is a random password set and it can never be unlocked. To fix this we set the keychain to never lock.