TLS 1.3 version support #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
tls13
branch
2 times, most recently
from
c68a324 to
979e3da
Compare
sfackler
reviewed
Aug 18, 2023
| /// | ||
| /// Requires OpenSSL 1.1.1 or LibreSSL 3.4.0 or newer. | ||
| #[cfg(have_tls13_version)] | ||
| Tlsv13, |
There was a problem hiding this comment.
I'd prefer to expose a uniform interface rather than having this be conditionally defined based on the backend version.
There was a problem hiding this comment.
I switched to runtime errors when unsupported.
amousset
commented
Aug 18, 2023
| @@ -24,7 +24,7 @@ libc = "0.2" | |||
| tempfile = "3.1.0" | |||
|
|
|||
| [target.'cfg(target_os = "windows")'.dependencies] | |||
| schannel = "0.1.17" | |||
| schannel = "0.1.20" | |||
There was a problem hiding this comment.
required as TLSv1.3 came with the switch from winapi to windows-rs in 0.1.20
|
@sfackler The comments were addressed, does the current PR look acceptable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #159, #235, #140
It looks like schannel and openssl > 1.1.1 (and compatible libressl) are the only compatible option for now:
security-frameworkdoes not (and will not) handle TLS 1.3 even if the constant exists.Relying on build-time check on openssl version makes it hard to use for downstream crates though. I don't see anything better than defining TLS 1.3 everywhere and enforcing a runtime error at connection instead.Switched to run time errors.