Remove unneeded checks for private key #259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably have an EC key in Sec1 format, not pkcs#8. The OpenSSL cli can help you convert your private key file to the appropriate format. |
|
Ok, now i feel stupid for not realizing this. Thanks for taking the time to reply! Will fix it on my end and close this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #238
THe problem is that EC keys slightly change the separator text and I don't think a check is needed on this level... what if, in the future, a different thing is added?
I think this is part of the appeal of using native TLS, that it can support things not originally supported. That is why I propose to remove the check altogether