-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow parsing several certificates from a single pem #168
base: master
Are you sure you want to change the base?
Conversation
The macos failure is unrelated to this issue. |
The functionality seems reasonable to me. Full PEM parsing isn't necessary for schannel, just the ability to identify the individual entries. You can probably pull the logic from another PR: https://github.com/sfackler/rust-native-tls/pull/147/files#diff-f3a4e813fbd2200f75435edfe7dcba3d |
@sfackler Will give this a look, thanks for the pointer! wrt naming, I didn't try and find some fancy naming and just borrowed the name from openssl. Not sure if we want a better name or if that's well enough |
stack_from_pem seems fine for now. I think we'd probably just make this the only interface in the next breaking release and rename to from_pem. |
@sfackler rebased on top on 0.2.9 and added impl for schannel based on PemBlock |
It looks like the windows build is red. |
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Heh, my bad sorry. Fixed the PemBlock namespacing. (I do not have access to a windows system though...) |
@sfackler any news on this? |
Is this something we might want to do? it would facilitate importing certificate chains.
Not sure about the security-framework impl which I haven't tested
Not sure how to do that with schannel, suggestions welcome