Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc refactoring > README.md and installation.md #673

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

pablos-here
Copy link

@pablos-here pablos-here commented Mar 28, 2023

Hi,

This unit of work affects the main landing page. It is part of issue #672.

I want to submit it for review to check whether the writing style is in-line with the project. Please let me know if the style should be adjusted and how, any other feedback. The documentation is not ready yet (see the questions below). :)

We can decide whether to add more units of work to this PR or release it and I work on another chunk. Let me know what you prefer. Either workflow works for me.

Questions

  1. Under manual installation, I'm unclear on the implications of Conda. What should we warn the user about?
  2. I moved the Installation to its own page with intention of keeping the main page short and simple. I can easily put it back if it is preferred.

@sezanzeb
Copy link
Owner

sezanzeb commented Mar 31, 2023

This tool may also be helpful for those with repetitive strain issues.

Please no medical advice in our docs

@pablos-here
Copy link
Author

This tool may also be helpful for those with repetitive strain issues.

Please no medical advice in our docs

Hi,

The intent was to convey that by remapping, you can address issues like Emacs pinky and the like. That's why I'm primarily using the solution.

If you feel strongly about it, we can simply strike it rather than re-word it.

I'm good either way.

Thx!

readme/installation.md Outdated Show resolved Hide resolved
Comment on lines 8 to 10
Please note that distributions may lag with the latest bug fixes. To
get the latest bug fixes, use the <a href="#manual-installation">Manual
installation</a> method.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lag", I have never seen that word used in that context

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Please note that distributions may provide more or less outdated packages."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"lag", I have never seen that word used in that context

In this context,it is a correct usage of lag.

I don't think we want to rewrite based on exposure to language.

"Please note that distributions may provide more or less outdated packages."

"more or less" is unfortunately incorrect because it is stating that a distribution may never have current packages. It is stating either more outdated or less outdated. I don't believe that's what we want to convey.

How about a slight modification as follows:

Please note that the distribution package may lag with the latest bug fixes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"more or less" is unfortunately incorrect because it is stating that a distribution may never have current packages.

Which is why my proposal says "distributions may provide".

I don't think we want to rewrite based on exposure to language.

I still don't like using lag like this.

Please use "Please note that distributions may provide more or less outdated packages."

readme/installation.md Outdated Show resolved Hide resolved
readme/installation.md Outdated Show resolved Hide resolved
readme/installation.md Outdated Show resolved Hide resolved
Comment on lines +92 to +93
<i><b>Warning:</b> the following will remove any existing <b>new</b>
configurations.</i>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<i><b>Warning:</b> the following will remove any existing <b>new</b>
configurations.</i>
<b>Warning:</b> the following commands will overwrite any new presets of
version 2.0.0 or later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the user creates configurations 2.0.0, then says oops, I want to migrate my beta configs, the rm will wipe them out. I brought forward the rm from the original doc. Is the rm not necessary? Should I strike that step?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<i><b>Warning:</b> the following will remove any existing <b>new</b>
configurations.</i>
<b>Warning:</b> the following commands will remove any new presets of
version 2.0.0 or later.

An easy to use tool to change the behaviour of your input devices.<br/>
Supports X11, Wayland, combinations, programmable macros, joysticks, wheels,<br/>
triggers, keys, mouse-movements and more. Maps any input to any other input.
<a href="readme/installation.md">Installation</a></br>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="readme/installation.md">Installation</a></br>
<a href="readme/installation.md">Installation</a> -

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that most users want to know how to install the software. This is why I put Installation on its own line. Perhaps later they'll come back for other activities such as Macros.

If you rather have Installation on the same line with everything else. I can do it but I wanted to explain my reasoning.

Let me know.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you rather have Installation on the same line with everything else

yes

@pablos-here
Copy link
Author

pablos-here commented Apr 3, 2023

Hi,

At your convenience, please have a look at this iteration.

A few notable (to me?) changes ...

On the installation.md, I went with the idea of removing the redundant warnings about lag. If it becomes a Support issue where people are fumbling around, we can tweak the doc.

On README.md, I centered the text (as it was) and created a two-column, bullet list of features. I also removed the repetitive strain text. Anyone who has it (like me), knows that a tool like input-remapper will alleviate the pain. :)

README.md Outdated Show resolved Hide resolved
readme/installation.md Outdated Show resolved Hide resolved
@sezanzeb
Copy link
Owner

sezanzeb commented Apr 4, 2023

There are also unaddressed old reviews from 4 days ago

@pablos-here
Copy link
Author

There are also unaddressed old reviews from 4 days ago

AFAIK, those issues are awaiting responses from you.

@sezanzeb
Copy link
Owner

sezanzeb commented Apr 4, 2023

for example #673 (comment)...

@pablos-here
Copy link
Author

for example #673 (comment)...

Near the end of my response, I say "let me know."

@jonasBoss jonasBoss linked an issue Apr 7, 2023 that may be closed by this pull request
@pablos-here
Copy link
Author

Hi Tobi,

It seems that you are very busy which is affecting the cadence of this PR. On my end, I've found a different key mapping solution that better matches my Use Cases.

As I see it, we have a couple of options. I can close the PR and either you hold onto the in-flight changes to complete or delete them.

To keep things tidy, one way or another, I'll close this PR within 24 hours from now.

Thanks!

@sezanzeb
Copy link
Owner

sezanzeb commented Apr 8, 2023

I don't know. I honestly can't see what is blocking you from resolving the three open review comments

@sezanzeb
Copy link
Owner

sezanzeb commented Apr 8, 2023

But yeah, you can keep it open and I'll add a label that someone else can continue this if wanted or something

@pablos-here
Copy link
Author

I don't know. I honestly can't see what is blocking you from resolving the three open review comments

Hey Tobi,

You never answered my follow up questions nor asked for further clarification so I was blocked.

@sezanzeb
Copy link
Owner

sezanzeb commented Apr 8, 2023

What exactly is the open question that blocks you from doing this:

image

?

@pablos-here
Copy link
Author

What exactly is the open question that blocks you from doing this:

image

?

Are you not able to see my responses?

Here's a screen scrape ...

scrape_20230408_091632

@sezanzeb
Copy link
Owner

sezanzeb commented Apr 8, 2023

It says "Pending", you have to submit your review so that I can see your comments

@pablos-here
Copy link
Author

It says "Pending", you have to submit your review so that I can see your comments

I had mentioned four days ago that I had written "let me know" but it clearly got missed. Now I know ... thx.

@pablos-here
Copy link
Author

Hi @sezanzeb ,

As I mentioned, I'm no longer using input-remapper. You'll need to take over this PR or I can close it.

Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation ideas
2 participants