Issue #847: Support assertWithMessage(...).fail() #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnveach
reviewed
Jun 6, 2021
...es/com/github/sevntu/checkstyle/checks/coding/InputRequireFailForTryCatchInJunitCheck11.java
Outdated
Show resolved
Hide resolved
...main/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheck.java
Outdated
Show resolved
Hide resolved
romani
requested changes
Jun 6, 2021
...main/java/com/github/sevntu/checkstyle/checks/coding/RequireFailForTryCatchInJunitCheck.java
Outdated
Show resolved
Hide resolved
pbludov
force-pushed
the
issue-847-assert-with-message-fail
branch
2 times, most recently
from
f266436 to
9556746
Compare
|
Sevntu regression on an existing check is only possible with https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/sevntu_launch_diff.sh . See checkstyle/contribution#340 . |
pbludov
force-pushed
the
issue-847-assert-with-message-fail
branch
from
9556746 to
a3cbe9c
Compare
pbludov
commented
Jun 7, 2021
| @@ -200,7 +202,7 @@ | |||
| final String failClassSimpleName = | |||
| failClassName.substring(lastDotPos + 1, failClassName.length()); | |||
|
|
|||
| // when "import org.junit.Assert" -> accept "Assertions.fail()" | |||
| // when "import org.junit.jupiter.api.Assertions" -> accept "Assertions.fail()" | |||
There was a problem hiding this comment.
Not related to this issue. Just a mistype.
Done: https://pbludov.github.io/issue-847-assert-with-message-fail/ |
rnveach
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #847
This is blocker for checkstyle/checkstyle#9142.