Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #610: standardized UTs from CheckstyleTestMakeup violations #621

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Issue #610: standardized UTs from CheckstyleTestMakeup violations #621

merged 1 commit into from
Nov 17, 2017

Conversation

rnveach
Copy link
Contributor

@rnveach rnveach commented Nov 17, 2017

Issue #610

This fixes all violations brought on by the new check at #620 .
I split it for faster merging.

@rnveach rnveach requested a review from romani November 17, 2017 02:31
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.75% when pulling 0b4892d on rnveach:issue_610_2 into 089680a on sevntu-checkstyle:master.

@rnveach
Copy link
Contributor Author

rnveach commented Nov 17, 2017 •
edited
Loading

travis failure is the weird issue with issue verification everything else passed.

@romani romani merged commit 741227f into sevntu-checkstyle:master Nov 17, 2017
@rnveach rnveach deleted the issue_610_2 branch November 17, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani Awaiting requested review from romani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnveach @coveralls @romani