feat: Remove useless message type in Terminal Interpreter

seung-00 · Nov 4, 2024 · 886ad7c · 886ad7c
1 parent 3575a3c
commit 886ad7c
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 16 deletions.
diff --git a/shell/src/main/java/org/apache/zeppelin/shell/terminal/service/TerminalService.java b/shell/src/main/java/org/apache/zeppelin/shell/terminal/service/TerminalService.java
@@ -50,10 +50,6 @@ public class TerminalService {
 
   private LinkedBlockingQueue<String> commandQueue = new LinkedBlockingQueue<>();
 
-  public void onTerminalInit() {
-    LOGGER.info("onTerminalInit");
-  }
-
   public void onTerminalReady() {
     TerminalService.startThread(() -> {
       try {

diff --git a/shell/src/main/java/org/apache/zeppelin/shell/terminal/websocket/TerminalSocket.java b/shell/src/main/java/org/apache/zeppelin/shell/terminal/websocket/TerminalSocket.java
@@ -64,12 +64,6 @@ public void onWebSocketText(String message) {
     if (messageMap.containsKey("type")) {
       String type = messageMap.get("type");
       switch (type) {
-        case "TERMINAL_INIT":
-          terminalService.onTerminalInit();
-          this.noteId = messageMap.get("noteId");
-          this.paragraphId = messageMap.get("paragraphId");
-          terminalManager.onWebSocketConnect(noteId, paragraphId);
-          break;
         case "TERMINAL_READY":
           terminalService.onTerminalReady();
           this.noteId = messageMap.get("noteId");

diff --git a/shell/src/main/resources/html/js/index.js b/shell/src/main/resources/html/js/index.js
@@ -46,12 +46,6 @@ function action(type, data) {
 }
 
 let app = {
-    onTerminalInit() {
-        // alert("TERMINAL_INIT");
-        ws.send(action("TERMINAL_INIT", {
-            noteId, paragraphId
-        }));
-    },
     onCommand(command) {
         ws.send(action("TERMINAL_COMMAND", {
             command