Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code with cargo fmt #279

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Reformat code with cargo fmt #279

merged 4 commits into from
Mar 18, 2024

Conversation

Nopey
Copy link
Contributor

@Nopey Nopey commented Mar 15, 2024

No description provided.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I noticed that this needed to be done! Would it be possible to make two changes here:

  1. Specify a stable rust version in the rust-toolchain.toml and include the rustfmt component.
  2. Add a CI job to run rustfmt --check to make sure this doesn't regress.

Thanks!

@Nopey
Copy link
Contributor Author

Nopey commented Mar 15, 2024

Added the CI step & pinned rustfmt version.

@Nopey Nopey requested a review from mrobinson March 15, 2024 21:37
Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the job definition above build_result and make sure that build_result depends on it. Otherwise, the CI will not fail if rustfmt --check fails.

Otherwise, I have a few nits:

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@mrobinson mrobinson added this pull request to the merge queue Mar 18, 2024
Merged via the queue into servo:main with commit f7eb174 Mar 18, 2024
16 checks passed
@atouchet atouchet mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants