-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat code with cargo fmt
#279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. I noticed that this needed to be done! Would it be possible to make two changes here:
- Specify a stable rust version in the
rust-toolchain.toml
and include therustfmt
component. - Add a CI job to run
rustfmt --check
to make sure this doesn't regress.
Thanks!
Added the CI step & pinned rustfmt version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the job definition above build_result
and make sure that build_result
depends on it. Otherwise, the CI will not fail if rustfmt --check
fails.
Otherwise, I have a few nits:
No description provided.