Skip to content

Only set PYTHONDONTWRITEBYTECODE env variable for subprocess #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

nicoburns
Copy link
Collaborator

env::set_var has become unsafe in the 2024 edition (rust-lang/rust#124866), so best that we avoid it.

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change request:

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but with that change this is good. Thanks!

@nicoburns nicoburns force-pushed the only-set-env-for-subprocess branch from 474c7aa to d3ff3d9 Compare April 1, 2025 07:55
@nicoburns nicoburns enabled auto-merge April 1, 2025 07:56
@nicoburns nicoburns added this pull request to the merge queue Apr 1, 2025
Merged via the queue into servo:main with commit 901b698 Apr 1, 2025
3 checks passed
@nicoburns nicoburns deleted the only-set-env-for-subprocess branch April 1, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants