Replace fxhash with rustc-hash #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 42990da Signed-off-by: Oriol Brufau <[email protected]> Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
…ed) (servo#99) Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
…l Stylo (servo#154) Signed-off-by: Barigbue <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
|
@paolobarbolini Thanks for the contribution. This crate is a downstream version of Gecko's style. We ask that non-Servo-specific changes be submitted upstream: https://searchfox.org/mozilla-central/source/servo/components. |
|
There's a guide to submitting patches to Gecko here: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html However, I would note that "fxhash" stands for Firefox Hash so I'm not sure how open they would be to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fxhashcrate hasn't been maintained in the last 6 years. This migrates torustc-hash, which is much more popular crate developed by the Rust project and used by the Rust compiler.