Fix cross-compiling with dylib feature #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is failing on main too, so probably that would need to be fixed first. |
Not again. |
When cross-compiling the host OS may be different from the target OS. E.g. one may be compiling for Linux on a Windows machine. In build-scripts one needs to reed the `TARGET` environment variables that cargo sets, since build scripts themselves are always compiled for the host platform.
jschwe
force-pushed
the
jschwender/cross_dylib
branch
from
5b644bc
to
33f672f
Compare
sagudev
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cross-compiling the host OS may be different from the target OS. E.g. one may be compiling for Linux on a Windows machine. In build-scripts one needs to reed the
TARGETenvironment variables that cargo sets,since build scripts themselves are always compiled for the host platform.
I came across this while investigating a different issue.