Make return type of TreeSink::elem_name an associated type.
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An unrelated clippy lint was failing. I've added an allow, although it seems to be a private item so we could update the variant names. |
|
Hmm... I don't think this actually works with |
nicoburns
force-pushed
the
extended-name-associated-type
branch
3 times, most recently
from
250c59f
to
da4e240
Compare
mrobinson
reviewed
Sep 10, 2024
nicoburns
force-pushed
the
extended-name-associated-type
branch
2 times, most recently
from
60db03f
to
c997ad8
Compare
jdm
approved these changes
Sep 10, 2024
nicoburns
force-pushed
the
extended-name-associated-type
branch
from
c997ad8
to
70be6a5
Compare
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
This allows this type to be owned or contain data protected by a RefCell or Mutex. It can also simply be `ExpandedName` - the type which was previously the return type of `TreeSink::elem_name` Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
extended-name-associated-type
branch
from
70be6a5
to
b5d84aa
Compare
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
This allows this type to be owned or contain data protected by a RefCell or Mutex. It can also simply be
ExpandedName- the type which was previously the return type ofTreeSink::elem_name.I have not yet had a chance to test this, but I believe this ought to fix my issue.