-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't ignore warnings in html5ever/src/tree_builder
#551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
This addresses the clippy::unreachable_pub lint Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
This fixes a clippy lint Signed-off-by: Simon Wülker <[email protected]>
These can all either use if-let branches or the matches! macro Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
This also fixes a clippy warning Signed-off-by: Simon Wülker <[email protected]>
This is necessary to allow html5ever to build (due to #[deny(warnings)]. We might want to remove these in the future, but I'm not sure whether they're necessary.
Signed-off-by: Martin Robinson <[email protected]>
mrobinson
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
html5ever/src/tree_builder/mod.rs
contains this:html5ever/html5ever/src/tree_builder/mod.rs
Line 10 in e6f0018
Presumably, this is done to ignore all the warnings caused by the
rules.rs
file generated at build time (Which is simply included inmod.rs
).However, this masks many warnings from the actual code itself. This PR instead puts the generated code into its own module, ignores warnings only for this specific module and then fixes (almost) all the warnings in the rest of the code.
There are two warnings that are not fixed by this PR:
Token
variants ending withToken
themselves (Token::TagToken
,Token::EOFToken
...). I didn't fix this because these variants are used directly without the enum name (TagToken
,EOFToken
...). Not a fan, but outside of the scope of this PRI've made individual commits for each "kind" of lint being addressed - I can squash these together if preferred.