Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to define static key-value pairs in Service Binding… #151

Closed
wants to merge 1 commit into from

Conversation

johnpoth
Copy link

… annotations (#140)

This is especially useful when defining Service Binding annotations in CRDs who's value are the same across all CRs. For example, the type and provider will be the same for Databases or Kafka brokers etc ...

Thanks !

@nebhale
Copy link
Member

nebhale commented Mar 17, 2021

@johnpoth Thanks for the contribution! I don't think that we're going to include this change because we're talking about a much more flexible approach to how mappings are done (#145). If you read that over, it becomes much clearer how static contributions might be added (TypeProvider notably, but almost any of the templates could do it too). It also frees us up to talk about Cluster-wide mappings.

It'd be great if you could chime in on #145 about how you think about the problem, and whether the described solution works for you.

@johnpoth
Copy link
Author

johnpoth commented Apr 2, 2021

Another advantage I came across is that it avoid users creating mappings and thus is less error prone then what the Spec offers today or described in #145.

If the a key/value pair is static and is defined in the CRD then it doesn't need to exist anywhere else. This makes one less field the user doesn't have to worry about.

I've updated the syntax a little bit to leverage Go templates, thanks !

@nebhale
Copy link
Member

nebhale commented Aug 5, 2021

This may be covered by an expansion/update of the Secret Generation Strategies covered by #161.

@johnpoth johnpoth closed this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants