Remove unused controller manager config #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunyiLyu
force-pushed
the
remove-unused-manager-config
branch
from
2982a4c to
eb45365
Compare
Signed-off-by: Chunyi Lyu <[email protected]>
ChunyiLyu
force-pushed
the
remove-unused-manager-config
branch
from
eb45365 to
79d6019
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage 77.75% 77.75%
=======================================
Files 19 19
Lines 1699 1699
=======================================
Hits 1321 1321
Misses 305 305
Partials 73 73 ☔ View full report in Codecov by Sentry. |
|
Thanks @ChunyiLyu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes controller_manager_config.yaml. This config file is currently not used in controller manager deployment and controller manager config (custom config) has been deprecated already. See:
kubernetes-sigs/controller-runtime#895
https://book.kubebuilder.io/component-config-tutorial/tutorial.html