fix: Firefox cross-origin object access #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: Resolve Firefox cross-origin object access issue in message port handling
Issue
Firefox was throwing the following error when attempting to send message from
window
context:Solution
The fix involves modifying how we handle the message port in the
getMessagePort
function. Instead of directly accessing and modifyingports[0]
, we now store it in a local variableport
. This approach avoids the cross-origin object access issue.Changes
In
src/internal/message-port.ts
:Impact
This change resolves the Firefox-specific error without affecting functionality on other browsers. It ensures consistent behavior across different browser environments when handling message ports in cross-origin contexts.
Testing
Please review and test this change to confirm it resolves the issue without introducing any regressions.