Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify language in info block on findFirstRow #177

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

macMikey
Copy link
Contributor

@macMikey macMikey commented Oct 7, 2024

per discussion #2814
orderBy is exceucted before the list is cut down

@macMikey macMikey force-pushed the crud-findFirst-plus-orderBy branch from 0ac5386 to 7bcbaac Compare October 7, 2024 13:26
Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @macMikey :)

I just a small nit comment here

docs/06-concepts/06-database/05-crud.md Outdated Show resolved Hide resolved
@macMikey macMikey force-pushed the crud-findFirst-plus-orderBy branch from 7bcbaac to 75e6a1b Compare October 7, 2024 17:29
orderBy is exceucted before the list is cut down

wupz. fix orderBy
@macMikey macMikey force-pushed the crud-findFirst-plus-orderBy branch from 75e6a1b to 4252d35 Compare October 7, 2024 17:34
Copy link
Contributor

@Isakdl Isakdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Isakdl Isakdl merged commit 2214364 into serverpod:main Oct 8, 2024
2 checks passed
@macMikey macMikey deleted the crud-findFirst-plus-orderBy branch October 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants