fix dependencies, tests, and clean code #35
Conversation
| "ts-node": "^8.10.2", | ||
| "tslint": "^5.20.1", | ||
| "typescript": "^3.9.10" | ||
| "@types/aws-lambda": "8.10.24", |
There was a problem hiding this comment.
Why dependencies are downgraded?
Are those packages not respecting semver?
There was a problem hiding this comment.
typescript doesn't at the least. You were getting a build error because the versions are out of sync with each other.
If we think we need to have the newer version then we should make a v2 that uses latest packages and node
There was a problem hiding this comment.
I simply followed semever and updated packages in version range that should not introduce breaking changes.
Majority of packages on npm follow semver, so it was pretty natural move, that normally works. It's kind of surprising it isn't here.
Therefore if you're sure that some of the bumped packages do not follow semver please fix them to a specific version, but rest should be safe with ^ versioning
There was a problem hiding this comment.
@medikoo I have packages updated where it will build with the newest.
KyloJorgensen
force-pushed
the
fix-depenecies
branch
from
0f66e3d to
cd5d28c
Compare
|
Merging this would fix any project using typescript |
|
@medikoo any chance you could look into this? The dependency on |
|
@perrin4869 thanks for heads-up, yet I'm no longer at Serverless Inc., and I don't have maintenance rights to push anything forward. AFAIK @Danwakeem takes care of handling contributions now. |
|
maybe @czubocha or @skierkowski can help here? would alleviate a lot of pain when typescript 5.3 is released 😅 |
No description provided.