Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SEPpy compatible with cdflib 1.3.3 #69

Merged
merged 6 commits into from
Jan 17, 2025

Conversation

jgieseler
Copy link
Member

cdflib fixed a very old bug in 1.3.3. Unfortunately, that change is breaking the workaround used so far to bypass the bug. This PR fixes the occuring problems while being backwards compatible to cdflib<1.3.3

@jgieseler jgieseler merged commit 967a685 into serpentine-h2020:main Jan 17, 2025
5 checks passed
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (7f75ff9) to head (d7d17bf).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   75.53%   75.61%   +0.08%     
==========================================
  Files          11       11              
  Lines        2342     2342              
==========================================
+ Hits         1769     1771       +2     
+ Misses        573      571       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant