Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spi classloader #1733

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chengyouling
Copy link
Collaborator

What type of PR is this?

Bug

What this PR does / why we need it?

fixed class load failed when have no ContextClassLoader.

Which issue(s) this PR fixes?

#1732

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@chengyouling chengyouling self-assigned this Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 34.48276% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ant/core/plugin/classloader/PluginClassLoader.java 0.00% 7 Missing ⚠️
...o/sermant/core/classloader/ClassLoaderManager.java 33.33% 3 Missing and 1 partial ⚠️
...terceptors/httpclient/HttpClient4xInterceptor.java 0.00% 4 Missing ⚠️
...ribe/processor/IntegratedEventListenerAdapter.java 0.00% 2 Missing ⚠️
...ynamic/config/inject/DynamicClassInjectDefine.java 0.00% 2 Missing ⚠️
...lancer/interceptor/SpringFactoriesInterceptor.java 0.00% 2 Missing ⚠️
...t/registry/inject/BaseAutoConfigurationDefine.java 0.00% 2 Missing ⚠️
...istry/interceptors/SpringFactoriesInterceptor.java 0.00% 2 Missing ⚠️
...registry/service/register/NacosServiceManager.java 0.00% 2 Missing ⚠️
...ptors/httpclient/HttpAsyncClient4xInterceptor.java 0.00% 2 Missing ⚠️
... and 9 more
Flag Coverage Δ Complexity Δ
unittests 42.48% <34.48%> (-0.01%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ Complexity Δ
.../main/java/io/sermant/core/utils/ReflectUtils.java 68.68% <100.00%> (ø) 0.00 <0.00> (ø)
...rvice/dynamicconfig/nacos/NacosBufferedClient.java 52.45% <100.00%> (ø) 0.00 <0.00> (ø)
...onfig/interceptors/SpringFactoriesInterceptor.java 65.11% <100.00%> (ø) 0.00 <0.00> (ø)
...lowcontrol/common/handler/retry/AbstractRetry.java 22.95% <100.00%> (+1.28%) 0.00 <0.00> (ø)
...flowcontrol/config/SpringFactoriesInterceptor.java 63.63% <100.00%> (ø) 0.00 <0.00> (ø)
...ct/FlowControlSpringConfigurationInjectDefine.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
.../flowcontrol/retry/ExtensionLoaderInterceptor.java 58.33% <100.00%> (ø) 0.00 <0.00> (ø)
...rmant/loadbalancer/interceptor/UrlInterceptor.java 76.00% <100.00%> (ø) 0.00 <0.00> (ø)
...cer/interceptor/RibbonLoadBalancerInterceptor.java 55.84% <100.00%> (ø) 0.00 <0.00> (ø)
.../io/sermant/dubbo/registry/utils/ReflectUtils.java 89.87% <100.00%> (ø) 0.00 <0.00> (ø)
... and 21 more

@chengyouling chengyouling force-pushed the develop-spi branch 2 times, most recently from 5abcc25 to 07eaeae Compare January 7, 2025 11:48
Signed-off-by: chengyouling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants