Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(save-modal): remove obsolete LocalStorageButton component #4464

Merged

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Feb 6, 2025

obsolete code since we now save all changes periodically to localStorage using the url (or part of it) as id

@hejtful hejtful requested a review from elbotho February 6, 2025 13:09
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Feb 6, 2025 1:12pm

Copy link
Contributor

github-actions bot commented Feb 6, 2025

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Eighteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/biologie 175.04 KB (🟢 -38 B) 280.41 KB
/chemie 175.04 KB (🟢 -38 B) 280.41 KB
/entity/create/[type]/[taxonomyId] 223.08 KB (🟢 -189 B) 328.46 KB
/entity/repository/add-revision/[...id] 222.75 KB (🟢 -189 B) 328.13 KB
/event/history 124.64 KB (🟢 -38 B) 230.01 KB
/event/history/[...slug] 125.62 KB (🟢 -38 B) 230.99 KB
/event/history/user/profile/[username] 128 KB (🟢 -38 B) 233.38 KB
/informatik 175.04 KB (🟢 -38 B) 280.41 KB
/lerntipps 175.04 KB (🟢 -38 B) 280.41 KB
/mathe 175.03 KB (🟢 -38 B) 280.41 KB
/nachhaltigkeit 175.04 KB (🟢 -38 B) 280.42 KB
/page/create 222.75 KB (🟢 -188 B) 328.13 KB
/subscriptions/manage 107.59 KB (🟢 -38 B) 212.97 KB
/taxonomy/term/create/[parent_id]/[id] 222.46 KB (🟢 -189 B) 327.83 KB
/taxonomy/term/update/[id] 222.38 KB (🟢 -189 B) 327.75 KB
/user/notifications 126.87 KB (🟢 -38 B) 232.25 KB
/user/profile/[username] 193.48 KB (🟢 -38 B) 298.86 KB
/user/settings 224.54 KB (🟢 -189 B) 329.91 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@elbotho elbotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
One follow up: The feedback is not very helpful now, we should probably still inform the user that they can come back, restore the content and try saving again later.

@hejtful
Copy link
Contributor Author

hejtful commented Feb 6, 2025

@elbotho Please feel free to change the message within this PR, or just leave the text as a comment and I'll change it.

@elbotho elbotho merged commit 28bb85d into staging Feb 10, 2025
8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants