-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify env vars and better debug output #3203
Conversation
Entkenntnis
commented
Dec 13, 2023
•
edited
Loading
edited
- to be sure that everything works I need a deployment - being careful
- remove branch protection rules for env checks
- maybe reduce output on dev
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Sixty-six Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
NEXT_PUBLIC_ENV=staging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an idea: If we would add a script like this we could remove .env
as well and make it even easier to find this functionality.
"dev-local": "cross-env NEXT_PUBLIC_ENV=local next",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the downside is that we either have to fall back to staging sometimes (like we already do in the code below) or set cross-env NEXT_PUBLIC_ENV=staging
for the dev
script as well.
// if env is not set, it's a production build running on localhost, use staging as default
const KRATOS_HOST =
KRATOS_HOSTS[
process.env.NEXT_PUBLIC_ENV ? process.env.NEXT_PUBLIC_ENV : 'staging'
]
We should probably do a test run with local api and kratos. |
Highest prio right now is the production deployment - I think your ideas are good and would like to persue them in follow-up issues. |