-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill in the blanks: Final preparation for release #3176
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the defaultLearnerFeedback
suggestion that we discussed, everything looks good to me!
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
103.72 KB (🟡 +35 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Thirty-six Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/ |
85.5 KB (🟢 -10 B) |
189.23 KB |
/[...slug] |
78.13 KB (🟡 +4.7 KB) |
181.85 KB |
/___bot_or_not |
95.36 KB (🟡 +4.59 KB) |
199.08 KB |
/___editor_preview |
477.65 KB (🟡 +1.72 KB) |
581.38 KB |
/___old_comments |
101.72 KB (🟡 +4 B) |
205.45 KB |
/auth/login |
80.73 KB (-1 B) |
184.46 KB |
/auth/oauth/login |
80.74 KB (-1 B) |
184.46 KB |
/auth/recovery |
62.62 KB (-1 B) |
166.34 KB |
/auth/registration |
63.56 KB (-1 B) |
167.29 KB |
/auth/settings |
63.68 KB (-1 B) |
167.4 KB |
/auth/verification |
62.97 KB (-1 B) |
166.7 KB |
/biologie |
156.54 KB (🟡 +4.91 KB) |
260.27 KB |
/chemie |
156.54 KB (🟡 +4.91 KB) |
260.26 KB |
/content-only/[...slug] |
71.96 KB (🟡 +4.28 KB) |
175.69 KB |
/discussions |
96.41 KB (🟡 +2 B) |
200.14 KB |
/editor |
104.37 KB (🟡 +4.78 KB) |
208.09 KB |
/entity/create/[type]/[taxonomyId] |
479.33 KB (🟡 +1.99 KB) |
583.05 KB |
/entity/link/order/[id]/link |
93.17 KB (🟡 +309 B) |
196.9 KB |
/entity/repository/add-revision/[...id] |
478.54 KB (🟡 +1.99 KB) |
582.27 KB |
/entity/repository/compare/[entity_id]/[revision_id] |
105.63 KB (🟡 +4.87 KB) |
209.36 KB |
/event/history |
129.58 KB (-6 B) |
233.31 KB |
/event/history/[...slug] |
133.34 KB (🟡 +7 B) |
237.06 KB |
/gleichungs-app |
164.83 KB (🟢 -377 B) |
268.56 KB |
/informatik |
156.54 KB (🟡 +4.91 KB) |
260.27 KB |
/lerntipps |
156.54 KB (🟡 +4.91 KB) |
260.27 KB |
/license/detail/[id] |
57.92 KB (🟡 +4.58 KB) |
161.65 KB |
/mathe |
156.54 KB (🟡 +4.91 KB) |
260.26 KB |
/nachhaltigkeit |
156.55 KB (🟡 +4.91 KB) |
260.27 KB |
/page/create |
478.56 KB (🟡 +1.99 KB) |
582.28 KB |
/taxonomy/term/[copyOrMove]/batch/[id] |
70.7 KB (-1 B) |
174.43 KB |
/taxonomy/term/create/[parent_id]/[id] |
478.25 KB (🟡 +1.99 KB) |
581.97 KB |
/taxonomy/term/sort/entities/[id] |
95.7 KB (🟡 +308 B) |
199.43 KB |
/taxonomy/term/update/[id] |
478.16 KB (🟡 +1.99 KB) |
581.89 KB |
/user/[...userslug] |
176.8 KB (🟡 +4.58 KB) |
280.52 KB |
/user/notifications |
132.32 KB (-5 B) |
236.05 KB |
/user/settings |
476.9 KB (🟡 +1.99 KB) |
580.63 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
Co-authored-by: Stephan Kulla <[email protected]>
apps/web/src/serlo-editor/plugins/fill-in-the-blanks-exercise/renderer.tsx
Outdated
Show resolved
Hide resolved
refactor(blank-exercise): Refactor toggleBlank()
@kulla Rerequested your review. Things that changed:
|
apps/web/src/serlo-editor/editor-ui/plugin-toolbar/text-controls/utils/blank.ts
Outdated
Show resolved
Hide resolved
refactor(gap-exercise): Shorten code for normalizeNode
Makes the plugin available also outside
staging
.Drag and drop mode is working on a basic level but there is no way for the user to change to this mode currently. Drag and drop mode will be worked on after this first release.
TODO before merge: