single email per push #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| //console.log('commit_msg: ' + commit_msg); | ||
| email += commit_msg; | ||
| callback(); |
There was a problem hiding this comment.
@jwu2
If this callback() is called too early, it might prematurely terminate the lambda function. AWS doesn't guarantee immediate termination so the function might still run for a bit.
There was a problem hiding this comment.
I think the callback is effective only for this commit. Not sure how it can be called too early. What is recommended way for this?
| return Promise.resolve({email:email,commit:e}); | ||
| }; | ||
| email += commit_msg; | ||
| callback(); |
There was a problem hiding this comment.
@jwu2 This can be moved to the end after sending the email
There was a problem hiding this comment.
I'm not sure about it, but have to test it out. The current code works well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.