Add prebuild for windows arm64 #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegecko
force-pushed
the
windows-arm
branch
from
c723f53
to
ad8eb1b
Compare
Julusian
approved these changes
Jul 2, 2024
|
Bump |
|
I think you can drop the targets and just add the arch and it should work now. |
|
To specify, drop the --target in the package.json and in the build - we can just target napi and we should be good now that 18 is our lowest supported node version. |
Done, lets see what gets built... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to node-usb/node-usb#735
This PR adds prebuild support for Windows arm64.
I notice there have been issues in the past building onwindows-2022, so this may fail and need putting back towindows-2019(untested)Switched to windows-2019.
Node builds for win32-arm64 didn't appear until node v20, so I've had to rework the targets so all other builds still use v14
Requires #168 to be merged first