Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent clickjacking attack #624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SenkaWolf
Copy link

@SenkaWolf SenkaWolf commented Jan 19, 2025

.htaccess updated to prevent iframes working with XBackBone installations.

Issue raised on #432

@sergix44
Copy link
Owner

I remember doing some research, but some people use XBB as a cdn, so there are cases where iframes are actually a wanted feature. Also, this would only "fix" installations behind apache, not nginx or other web servers, and requires mod_headers to be enabled, otherwise a 500 is raised.
Since this problem is not really application dependent, but rather deployment/use-case/webserver dependent, I don't feel comfortable merging this.
It's possible having a middleware that set that header behind a feature flag maybe 🤔

@SrS2225a
Copy link
Contributor

Could potentially do what VaultWarden currently does for Iframes to fix this issue and that is an configurable option to choose allowed iframe ancestors and allowed connect-src. Maybe there could also be an option to define which domains can use iframes

More info (explanation from VaultWarden):
[allowed_iframe_ancestors] Allows other domains to embed the web vault into an iframe, useful for embedding into secure intranets.
[allowed_connect_src] Allows other domains to URLs which can be loaded using script interfaces like the Forwarded email alias feature

This would fix the clickjacking attack while still allowing XBackBone admins to use iframes if they so which.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants