Added support for HTML fragments in Document Assembler Content tag #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and a Tutorial under docs.
Updated DA Multiline content test because the HtmlConverter creates paragraphs rather than inserting soft line breaks.
…nts in a Content select (joins them with a new line). Ran csharpier on all files. Added HtmlAgilityPack to paket references.
…t rather than using paket initially!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Sergey,
Hope you are well and thanks for merging my previous PRs.
This PR adds support for using HTML fragments with the Content tag in Document Assembler. The supported inline tags are:
Both div and p tags are supported block level tags, any other HTML tag will simply be ignored. Tags can be combined so for example the following works:
<a href="bbc.co.uk"><b><i><u>BBC</u></i></b></a>I have added a new test, and a tutorial to the docs site.
This resolves #70 in my opinion although as noted in the Tutorial there are some other tags that we could potentially add support for.
One thing to note is that this adds a dependency on the HTMLAgilityPack.
Any questions then let me know, I'll hopefully do another PR later in the week for supporting pulling in Document/Templates from other sources.
Cheers,
Malcolm