Skip to content

Commit

Permalink
Dropped chromedriver in favour of WebdrvierIO browser management feature
Browse files Browse the repository at this point in the history
  • Loading branch information
jan-molak committed Aug 1, 2023
1 parent b54e5f8 commit 42a69cb
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 159 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ jobs:
node-version: ${{ matrix.node-version }}
- name: Setup Node Modules
uses: bahmutov/npm-install@v1
env:
CHROMEDRIVER_FILEPATH: "/usr/bin/chromedriver"
- run: npm run lint
- run: npm test
env:
Expand Down
158 changes: 6 additions & 152 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,11 @@
"@wdio/globals": "^8.14.1",
"@wdio/local-runner": "^8.14.1",
"@wdio/spec-reporter": "^8.14.0",
"wdio-chromedriver-service": "^8.1.1",
"webdriverio": "^8.14.1"
},
"devDependencies": {
"@typescript-eslint/eslint-plugin": "^6.2.1",
"@typescript-eslint/parser": "^6.2.1",
"chromedriver": "^115.0.0",
"eslint": "^8.46.0",
"eslint-plugin-import": "^2.28.0",
"eslint-plugin-simple-import-sort": "^10.0.0",
Expand Down
7 changes: 4 additions & 3 deletions wdio.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ export const config: WebdriverIOConfig = {
// maxInstances: 5,
//
browserName: 'chrome',

// See https://webdriver.io/blog/2023/07/31/driver-management
browserVersion: 'stable',

acceptInsecureCerts: true,
// If outputDir is provided WebdriverIO can capture driver session logs
// it is possible to configure which logTypes to include/exclude.
Expand Down Expand Up @@ -158,9 +162,6 @@ export const config: WebdriverIOConfig = {
// your test setup with almost no effort. Unlike plugins, they don't add new
// commands. Instead, they hook themselves up into the test process.
outputDir: 'target/logs',
services: [
[ 'chromedriver', { } ]
],

//
// The number of times to retry the entire specfile when it fails as a whole
Expand Down

0 comments on commit 42a69cb

Please sign in to comment.