Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate RestStepListener (#3540) #3543

Merged
merged 1 commit into from
Sep 25, 2024
Merged

refactor: deprecate RestStepListener (#3540) #3543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions serenity-rest-assured/src/main/java/net/serenitybdd/rest/RestStepListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

import net.thucydides.model.steps.StepListenerAdapter;

/**
* @deprecated With no replacement, since {@code RestStepListener} no longer performs any operations.
*/
@Deprecated(since="4.2.2")
public class RestStepListener extends StepListenerAdapter {

}
5 changes: 0 additions & 5 deletions serenity-rest-assured/src/main/java/net/serenitybdd/rest/utils/RestReportingHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
import net.serenitybdd.core.Serenity;
import net.serenitybdd.model.rest.RestMethod;
import net.serenitybdd.model.rest.RestQuery;
import net.serenitybdd.rest.RestStepListener;
import net.serenitybdd.rest.decorators.request.RequestSpecificationDecorated;
import net.serenitybdd.rest.event.RecordRestQueryEvent;
import net.serenitybdd.rest.filters.FieldsRecordingFilter;
Expand Down Expand Up @@ -39,10 +38,6 @@
*/
public class RestReportingHelper {

public RestReportingHelper() {
getParallelEventBus().registerListener(new RestStepListener());
}

private static boolean shouldRecordResponseBodyFor(Response result) {
final ContentType type = ContentType.fromContentType(result.contentType());
return type != null && (ContentType.JSON == type || ContentType.XML == type
Expand Down
Loading