Phase out precompiled #2590
Merged
Phase out precompiled #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Aug 21, 2023
There was a problem hiding this comment.
To clarify, I don't actually think #2588 has anything to do with the ability to undo precompiled. Serde_derive is going to continue to be slow to compile after this. The version equality constraint thing is an independent improvement that's useful for cases that already depend on serde / serde_derive separately to parallelize the (still slow) builds (niklasmohrin/clircle#12, pfernie/cookie_store#37, dtolnay/noisy-clippy@3838953, …).
Could you unstack this from #2588 if it includes anything from there as indicated by your PR description? I was hoping this one could land first. For the other one it may turn out to be wise to wait several weeks in case there are some unsatisfiable constraints floating around like serde = "1.0.177", serde_derive = "=1.0.171" in the near term, which that PR would break. I might need to write tooling to detect that.
|
yup done unstacked |
This PR phases out the precompiled per final consensus made in serde-rs#2580 i# Fix a cfg
pinkforest
force-pushed
the
phase-out-precompiled
branch
from
61555bf
to
360606b
Compare
|
Sorry bad old habit squashing my branch 😬 😅 |
0xpr03
added a commit
to notify-rs/notify
that referenced
this pull request
Aug 21, 2023
the experiment got removed in serde-rs/serde#2590
0xpr03
added a commit
to notify-rs/notify
that referenced
this pull request
Aug 21, 2023
the experiment got removed in serde-rs/serde#2590
0xpr03
added a commit
to notify-rs/notify
that referenced
this pull request
Aug 21, 2023
the experiment got removed in serde-rs/serde#2590
0xpr03
added a commit
to notify-rs/notify
that referenced
this pull request
Aug 21, 2023
the experiment got removed in serde-rs/serde#2590
0xpr03
added a commit
to notify-rs/notify
that referenced
this pull request
Aug 21, 2023
the experiment got removed in serde-rs/serde#2590
matklad
added a commit
to matklad/rust-analyzer
that referenced
this pull request
Aug 21, 2023
Sered no longer uses blobs as of serde-rs/serde#2590 As such, there's no longer need for us to pin it. Note that this doesn't upgrade serde version we use: I am fairly confident that the blobs are already there are fine, and now I am fairly confident that all future versions of serde will be fine as well.
|
Sorry for the confusion but what's the final conclusion on the default behavior? How should binaries decide to pick their desired build process? |
|
The binary has been deleted entirely so there is no choice, only the from source option. |
eightfilms
added a commit
to 0xmozak/mozak-vm
that referenced
this pull request
Aug 22, 2023
Reverts commit 9bb636e. The whole fiasco over shipping precompiled binaries with serde_derive was resolved with a [new release](https://github.com/serde-rs/serde/releases/tag/v1.0.184). See this [PR](serde-rs/serde#2590) as well - seems like the maintainer took active steps to make sure the precompile was phased out after listening to feedback.
uncomfyhalomacro
pushed a commit
to uncomfyhalomacro/rypper
that referenced
this pull request
Aug 22, 2023
As the consensus was concluded across the rust community, this PR serde-rs/serde#2590 phases out precompiled blobs from serde_derive. Signed-off-by: Soc Virnyl Estela <[email protected]>
uncomfyhalomacro
pushed a commit
to uncomfyhalomacro/rypper
that referenced
this pull request
Aug 22, 2023
As the consensus was concluded across the rust community, this PR serde-rs/serde#2590 phases out precompiled blobs from serde_derive. Signed-off-by: Soc Virnyl Estela <[email protected]>
eightfilms
added a commit
to 0xmozak/mozak-vm
that referenced
this pull request
Aug 22, 2023
Reverts commit 9bb636e. The whole fiasco over shipping precompiled binaries with serde_derive was resolved with a [new release](https://github.com/serde-rs/serde/releases/tag/v1.0.184). See this [PR](serde-rs/serde#2590) as well - seems like the maintainer took active steps to make sure the precompile was phased out after listening to feedback.
martin-g
added a commit
to apache/avro
that referenced
this pull request
Aug 22, 2023
Suggested-at: serde-rs/serde#2590 Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
added a commit
to apache/avro
that referenced
this pull request
Aug 22, 2023
Suggested-at: serde-rs/serde#2590 Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
added a commit
to apache/avro
that referenced
this pull request
Aug 22, 2023
Suggested-at: serde-rs/serde#2590 Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
added a commit
to apache/avro
that referenced
this pull request
Aug 22, 2023
Suggested-at: serde-rs/serde#2590 (review) Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Aug 22, 2023
internal: unpin serde Serde no longer uses blobs as of serde-rs/serde#2590 As such, there's no longer need for us to pin it. Note that this doesn't upgrade serde version we use: I am fairly confident that the blobs are already there are fine, and now I am fairly confident that all future versions of serde will be fine as well.
FWuermse
added a commit
to flow-rs/flowrs-wasm
that referenced
this pull request
Aug 24, 2023
FWuermse
added a commit
to flow-rs/flowrs-std
that referenced
this pull request
Aug 24, 2023
FWuermse
added a commit
to flow-rs/flowrs
that referenced
this pull request
Aug 24, 2023
aDotInTheVoid
added a commit
to aDotInTheVoid/triphosphate
that referenced
this pull request
Sep 1, 2023
spmadden
added a commit
to spmadden/irox
that referenced
this pull request
Sep 18, 2023
11Kilobytes
added a commit
to 11Kilobytes/kanata
that referenced
this pull request
Oct 31, 2023
See serde-rs/serde#2590 for more details.
4 tasks
11Kilobytes
added a commit
to 11Kilobytes/kanata
that referenced
this pull request
Oct 31, 2023
See serde-rs/serde#2590 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following consensus on: #2580 (review)
This PR phases out the precompiled per final consensus made in #2580