Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field_identifier and variant_identifier container attributes #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobz1000
Copy link
Contributor

@tobz1000 tobz1000 commented Jan 3, 2020

These sections are taken from PR #96, where they were initially rejected, because they are not particularly useful for automatic derive.

I'm submitting them again for consideration, for a few reasons:

  • This comment makes mention of (ab)using field_identifier without understanding its purpose. Putting aside whether this should be done, it would be helpful for people who come across it during experimentation to understand it.
    • Possibly as a result of the above issue, field_identifier is mentioned in that crate's docs. This is where I found myself in need of a quick refresher on what this attribute actually does.
  • So far, there is no other mention of these attributes in the documentation.
  • I believe it makes sense to have an exhaustive listing of possible attributes somewhere. Having that list across the "attributes" pages makes sense enough.

I also had a quick look at the history of serde_derive/.../attr.rs, and it seems like there are no other undocumented attributes to add at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant