Merge pull request #3104 from smehringer/io_performance

[FEATURE] Minor increase in FASTA performance.
seqan · Nov 28, 2022 · 1ac7b8a · 1ac7b8a · vercel · Nov 28, 2022
2 parents 89932c0 + b1709f3
commit 1ac7b8a
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/include/seqan3/io/sequence_file/format_fasta.hpp b/include/seqan3/io/sequence_file/format_fasta.hpp
@@ -309,16 +309,21 @@ class format_fasta
 
             for (; (it != e) && ((!is_id)(*it)); ++it)
             {
-                if ((is_space || is_digit)(*it))
+                if (is_legal_alph(*it))
+                {
+                    seq.push_back(assign_char_to(*it, std::ranges::range_value_t<seq_type>{}));
+                }
+                else if ((is_space || is_digit)(*it))
+                {
                     continue;
-                else if (!is_legal_alph(*it))
+                }
+                else
                 {
+
                     throw parse_error{std::string{"Encountered an unexpected letter: "} + "char_is_valid_for<"
                                       + detail::type_name_as_string<seq_legal_alph_type>
                                       + "> evaluated to false on " + detail::make_printable(*it)};
                 }
-
-                seq.push_back(assign_char_to(*it, std::ranges::range_value_t<seq_type>{}));
             }
 
 #else  // ↑↑↑ WORKAROUND | ORIGINAL ↓↓↓