[MISC] Add max_bin_elements to IBF constructor #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
|
Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/236 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 51 51
Lines 1930 1932 +2
Branches 5 5
=======================================
+ Hits 1923 1925 +2
Misses 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sometimes the maximum bin elements might be known. For example, in Raptor, I know the maximum count for minimizer files without going through them.
eseiler
force-pushed
the
misc/ibf_ctor
branch
from
c7de31c to
ddb823f
Compare
seqan-actions
added
lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the maximum bin elements might be known. For example, in Raptor, I know the maximum count for minimizer files without going through them.
This ctor will allow me to use the hibf lib to create IBFs in Raptor.