[FEATURE] Add data_store::validate #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seqan-actions
added
lint
|
Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/230 |
eseiler
force-pushed
the
infra/check_datastore
branch
from
4dd58ff to
4522c28
Compare
seqan-actions
added
lint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 50 51 +1
Lines 1915 1930 +15
Branches 5 5
=======================================
+ Hits 1908 1923 +15
Misses 7 7 ☔ View full report in Codecov by Sentry. |
smehringer
requested changes
Sep 11, 2024
src/layout/hierarchical_binning.cpp
Outdated
| @@ -40,7 +39,8 @@ size_t hierarchical_binning::execute() | |||
|
|
|||
| if (!config.disable_estimate_union && !config.disable_rearrangement) | |||
| { | |||
| assert(data->sketches != nullptr); | |||
| if (data->sketches == nullptr) | |||
| throw std::invalid_argument{"[HIBF ERROR] data_store::sketches must not be nullptr."}; | |||
There was a problem hiding this comment.
Suggested change
| throw std::invalid_argument{"[HIBF ERROR] data_store::sketches must not be nullptr."}; | |
| throw std::invalid_argument{"[HIBF ERROR] data_store::sketches must not be nullptr is union estimation or rearrangement is enabled."}; |
eseiler
force-pushed
the
infra/check_datastore
branch
from
4522c28 to
8d6defe
Compare
seqan-actions
added
lint
eseiler
force-pushed
the
infra/check_datastore
branch
from
8d6defe to
273f7f4
Compare
seqan-actions
added
lint
smehringer
approved these changes
Sep 12, 2024
|
@eseiler Do we want to keep the commits? Seems sensible but you have the last call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of #227