Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Overwrite kmer and window configuration from sketch file to current config. #273

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

smehringer
Copy link
Member

I just had this use case.

I created a sketch file with k=32, w=32.

Then I ran chopper with the sketch file without setting k and w again on the command line (since in the layout I am not re-sketching and besides sketching I do not use k and w).

I compared some layouts and noticed that my layout file (created as above from a sketch file) stated k=19, w=19. Now even though the layout shouldn't be influenced, this is wrong for the subsequent build step. Because when building from layout I do not reconfigure k and w. So my index will be built on k=19 and w=19. :(

@seqan-actions seqan-actions added lint and removed lint labels Nov 27, 2024
@smehringer smehringer requested a review from eseiler November 27, 2024 09:46
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/chopper/273

@seqan-actions seqan-actions added lint and removed lint labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.53%. Comparing base (1222ae9) to head (1cae4a8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/chopper_layout.cpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   95.64%   95.53%   -0.11%     
==========================================
  Files          20       20              
  Lines         758      762       +4     
  Branches       16       17       +1     
==========================================
+ Hits          725      728       +3     
- Misses         33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler merged commit 30c9acc into seqan:main Nov 27, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants