[UTIL,FEATURE] display_layout: Also compute FPR corrected sizes. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview available at https://docs.seqan.de/preview/seqan/chopper/264 |
eseiler
force-pushed
the
display_layout_fpr_corrected
branch
from
0f6f066 to
709eceb
Compare
Co-authored-by: Enrico Seiler <[email protected]>
eseiler
force-pushed
the
display_layout_fpr_corrected
branch
from
709eceb to
ed0086b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 20 20
Lines 758 758
Branches 15 15
=======================================
Hits 725 725
Misses 33 33 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a case with a few merged bins within several single bins.
The current display layout looked like this:
default.layoutsub171.layout.sizes.general.pdf
Which is not really the actual case. Merged bins are size corrected with the relaxed FPR within the DP while split bins are corrected for multiple testing. I incoorporated this into display_layout. Now it looks like this:
default.layoutsub171.layout.new.general.pdf
which makes more sense for a result of the DP algorithm.