Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow multiple filenames per user bin. #237

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

smehringer
Copy link
Member

@smehringer smehringer commented Dec 4, 2023

Fixes #196

@seqan-actions seqan-actions added lint and removed lint labels Dec 4, 2023
src/layout/output.cpp Outdated Show resolved Hide resolved
src/layout/output.cpp Outdated Show resolved Hide resolved
@seqan-actions seqan-actions added lint and removed lint labels Dec 5, 2023
@smehringer smehringer requested a review from eseiler December 5, 2023 09:31
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (17d067b) 95.82% compared to head (8521f01) 95.74%.

Files Patch % Lines
src/input_functor.cpp 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   95.82%   95.74%   -0.08%     
==========================================
  Files          19       19              
  Lines         719      729      +10     
==========================================
+ Hits          689      698       +9     
- Misses         30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler enabled auto-merge December 6, 2023 12:02
@seqan-actions seqan-actions added lint and removed lint labels Dec 6, 2023
@eseiler eseiler merged commit bdcecb6 into seqan:main Dec 6, 2023
23 checks passed
@smehringer smehringer deleted the multi_filenames branch December 7, 2023 08:56
@smehringer smehringer mentioned this pull request Dec 14, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Allow chopper input to have multiple files per line / user bin
3 participants