Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] parallel display_layout general #222

Merged
merged 2 commits into from
Oct 23, 2023
Merged

[FEATURE] parallel display_layout general #222

merged 2 commits into from
Oct 23, 2023

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Oct 19, 2023 •
edited
Loading

Todo:

  • sorted output
  • split bins

@seqan-actions seqan-actions added lint and removed lint labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92f29f5) 95.94% compared to head (c98e025) 95.94%.

❗ Current head c98e025 differs from pull request most recent head b5544a7. Consider uploading reports for the commit b5544a7 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          19       19           
  Lines         690      690           
=======================================
  Hits          662      662           
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eseiler eseiler requested review from smehringer and removed request for smehringer October 19, 2023 15:52
@seqan-actions seqan-actions added lint and removed lint labels Oct 19, 2023
@eseiler eseiler requested a review from smehringer October 19, 2023 17:34
@seqan-actions seqan-actions added lint and removed lint labels Oct 19, 2023
smehringer
smehringer reviewed Oct 20, 2023
View reviewed changes
src/util/display_layout/general.cpp Show resolved Hide resolved
src/util/display_layout/general.cpp Outdated Show resolved Hide resolved
src/util/display_layout/general.cpp Show resolved Hide resolved
src/util/display_layout/general.cpp Show resolved Hide resolved
@eseiler eseiler requested a review from smehringer October 20, 2023 10:33
@seqan-actions seqan-actions added lint and removed lint labels Oct 20, 2023
@smehringer
Copy link
Member

Thanks for the nice comments!

@eseiler eseiler enabled auto-merge October 23, 2023 08:16
@seqan-actions seqan-actions added lint and removed lint labels Oct 23, 2023
@eseiler eseiler merged commit 7767b99 into seqan:main Oct 23, 2023
18 checks passed
@eseiler eseiler deleted the feature/parallel branch October 23, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smehringer smehringer smehringer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eseiler @smehringer @seqan-actions