Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support python<3.9, by importing typing types #47

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Conversation

dfguerrerom
Copy link
Contributor

  • It fails with python == 3.8.10

@dfguerrerom
Copy link
Contributor Author

the test is failing because of the missing gee token on the actions env... I'm not really sure how to get a non service account token for gee as it is on sepal_ui, but I'd be happy to create one for sepal-contrib

@dfguerrerom dfguerrerom marked this pull request as ready for review August 25, 2023 14:40
@dfguerrerom
Copy link
Contributor Author

dfguerrerom commented Aug 29, 2023

@12rambau, I don't want to bother you, but just in case you're using it outside.

@12rambau
Copy link
Collaborator

no problem, I guess the env key reached end of life.
I always forget what I should be doing so usually I reproduced the process described in https://sepal-ui.readthedocs.io/en/latest/start/contribute.html#env-for-gee-component

@dfguerrerom dfguerrerom merged commit 9d612c3 into main Aug 29, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants